Avoid double-decoding on attribute value #4797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ding issue,i.e. get `"` after decoding `"` while `"` is expected.
yyx990803
requested changes
Jan 27, 2017
| .replace(gtRE, '>') | ||
| .replace(ampRE, '&') | ||
| .replace(quoteRE, '"') | ||
| const re = shouldDecodeNewlines ? /&(lt|gt|quot|amp|#10);/g : /&(lt|gt|quot|amp);/g |
There was a problem hiding this comment.
Can we hoist the two RegExps out so that they don't get instantiated on every call?
|
Good catch! |
|
It took me one hour to come up with the variable names:sob: |
Codecov Report
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chained
replaces here may cause problems if the order isn't carefully arranged.Currently we get"after decoding"while"is expected.For a quick fix, I could move the
replacewhich replaces&s to the last.However, I prefer one singlereplaceso that we don't bother with chaining order.