Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support select multiple binding (fix #4755) #4756

Merged
merged 4 commits into from
Jan 19, 2017
Merged

Support select multiple binding (fix #4755) #4756

merged 4 commits into from
Jan 19, 2017

Conversation

defcc
Copy link
Member

@defcc defcc commented Jan 19, 2017

Determine multiple in runtime. fix #4755


const assignment = `$event.target.multiple ? ${selectedVal}: ${selectedVal}[0]`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can make the generated code quite verbose since selectedVal is repeated twice. We can store it in a runtime temp variable (e.g. $$selectedVal)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, I'll update it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@yyx990803 yyx990803 merged commit 9e38abc into vuejs:dev Jan 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug with dynamic binding multiple for select tag.
2 participants