-
-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: prevent snoretoast shortcut, set notif title (#2720) #6000
Conversation
This prevents SnoreToast from installing a Start Menu shortcut by specifying an appID. The appID is also used to set the notification's title bar text in Windows 10. That text is now set to "Vue UI", which replaces the default value of "SnoreToast". fixes vuejs#2720
// SnoreToast actually uses it as the string in the notification's | ||
// title bar (different from title heading inside notification). | ||
// This only has an effect in Windows. | ||
const snoreToastOptions = notifier.Notification === notifier.WindowsToaster && { appID: 'Vue UI' } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
notifier.Notification
is set to WindowsToaster
, which uses SnoreToast
I only set appID
for SnoreToast to avoid any effects on other notifiers that might also have an appID
parameter.
Once this fix lands, users may want to manually undo the SnoreToast changes from their system, as described below. Remove SnoreToast shortcut from Start MenuOption A: File Explorer
Option B: Windows Command Line
Remove SnoreToast's registry keyNote: SnoreToast sets a registry key in order to register its notification center. The UUID seen in the key is for SnoreToast v0.7.0. Option A: Registry Editor
Option B: Windows Command Line
|
This is a good thing to have |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for the fix and the detailed guidance!
This prevents SnoreToast from installing a Start Menu shortcut by specifying an appID. The appID is also used to set the notification's title bar text in Windows 10. That text is now set to "Vue UI", which replaces the default value of "SnoreToast". fixes #2720
This prevents SnoreToast from installing a Start Menu shortcut by specifying an
appID
. TheappID
is also used to set thenotification's title bar text in Windows 10. That text is now set to "Vue UI", which replaces the default value of "SnoreToast".
fixes #2720
Screenshot of desktop notification on Windows 10:
Screenshot of notification bar on Windows 10:
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
Other information: