fix: update vue-shims for Vue v3.0.1 #5975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 16, 2020
FossPrime
approved these changes
Oct 16, 2020
pikax
reviewed
Oct 18, 2020
| @@ -1,5 +1,5 @@ | |||
| declare module '*.vue' { | |||
| import type { DefineComponent } from 'vue' | |||
| const component: DefineComponent | |||
| const component: DefineComponent<any, any, any> | |||
There was a problem hiding this comment.
DefineComponent<{}, {}, any>
maybe?
There was a problem hiding this comment.
👍 Yes, now that VTU beta.7 is out, this is enough.
vuejs/core@6aa2256 intriduced a change in `DefineComponent` type, that results in a broken bare CLI app that would use VTU, as `mount` will not compile. This relaxes the type definitation by using generic `any`. Fixes vuejs#5974
cexbrayat
force-pushed
the
fix/vue-301-shims
branch
from
5c1b57e to
6d42778
Compare
|
I updated the PR to use |
pikax
approved these changes
Oct 18, 2020
|
Thanks! |
|
I just created an app with vue/cli v4.5.8 . It looks like it uses Vue v3.0.2 and Vue Test Utils v2.0.0-beta.7 and I'm still having the same issue when I run the default unit test. The exact error is as follows: Any idea? |
|
@alperkay that's a different matter. This PR targets a typing (i.e. compile-time) issue, yours is a runtime issue (missing prop declaration?) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
Other information:
vuejs/core@6aa2256 intriduced a change in
DefineComponenttype, that results in a broken bare CLI app that would use VTU, asmountwill not compile.This relaxes the type definitation by using generic
any.Fixes #5974