Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(language-core): reduce virtual code generated by component tags #4714

Merged
merged 18 commits into from
Aug 27, 2024

Conversation

johnsoncodehk
Copy link
Member

@johnsoncodehk johnsoncodehk commented Aug 22, 2024

Refactors

  • Generate var_defineComponentCtx definition on demand
  • Only generate auto import completion virtual code for editing scripts
  • Use shouldReport to filter errors instead of generating two sets of virtual code for props type check
  • Generate virtual code used only for renaming and find references as JSDoc

Copy link

pkg-pr-new bot commented Aug 22, 2024

commit: 2c3a134

vue-component-meta

pnpm add https://pkg.pr.new/vuejs/language-tools/vue-component-meta@4714

vue-component-type-helpers

pnpm add https://pkg.pr.new/vuejs/language-tools/vue-component-type-helpers@4714

@vue/language-core

pnpm add https://pkg.pr.new/vuejs/language-tools/@vue/language-core@4714

@vue/language-plugin-pug

pnpm add https://pkg.pr.new/vuejs/language-tools/@vue/language-plugin-pug@4714

@vue/language-server

pnpm add https://pkg.pr.new/vuejs/language-tools/@vue/language-server@4714

@vue/language-service

pnpm add https://pkg.pr.new/vuejs/language-tools/@vue/language-service@4714

vue-tsc

pnpm add https://pkg.pr.new/vuejs/language-tools/vue-tsc@4714

@vue/typescript-plugin

pnpm add https://pkg.pr.new/vuejs/language-tools/@vue/typescript-plugin@4714

Open in Stackblitz

@johnsoncodehk johnsoncodehk marked this pull request as ready for review August 27, 2024 16:00
@johnsoncodehk johnsoncodehk merged commit 5936c82 into master Aug 27, 2024
9 checks passed
@johnsoncodehk johnsoncodehk deleted the simplify-virtual-code branch August 27, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant