fix(tsc): re-introduce global types removal check #4245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The issue with the guard clause prior was that the out directory for the .d.ts file is likely to be a different place from the global types holder file. This meant the clause was not accurately detecting if it should remove the global types. The guard clause is needed to some degree as large projects with many emitted files would run this removal which is fairly slow. vue-tsc is unusable without this guard clause. Instead just get the file name from the file being written and the global types holder, if the dts file starts with the global types holder then perform the global types removal logic. This allows for the output and source paths to be different. The removal may run more than once if similar names are present but it won't run on every file to be emitted.
|
Thanks for the PR! Can you share how much the build time improved by introducing this condition in your case? |
|
Our application:
Full build no guard check |
|
Another data point: Our build slowed down by about 50% with the latest version. |
|
I haven't been able to reproduce the performance difference caused by this change. I would merge it first, but we'd better have a test case for this in case it breaks again in the future. |
|
For my project: Before 2.0.12: After 2.0.13: 80% faster |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue with the guard clause prior was that the out directory for the .d.ts file is likely to be a different place from the global types holder file. This meant the clause was not accurately detecting if it should remove the global types.
The guard clause is needed to some degree as large projects with many emitted files would run this removal which is fairly slow. vue-tsc is unusable without this guard clause.
Instead just get the file name from the file being written and the global types holder, if the dts file starts with the global types holder then perform the global types removal logic.
This allows for the output and source paths to be different. The removal may run more than once if similar names are present but it won't run on every file to be emitted.