Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TypeScript errors are not displayed in terminal with --incremental (vue-tsc@2) #4194

Closed
wangshunnn opened this issue Apr 2, 2024 · 1 comment
Closed

TypeScript errors are not displayed in terminal with --incremental (vue-tsc@2) #4194

wangshunnn opened this issue Apr 2, 2024 · 1 comment
Labels
bug Something isn't working good reproduction ✨ This issue provides a good reproduction, we will be able to investigate it first upstream

Comments

@wangshunnn
Copy link

Related issue

Description

At first I had the same issue as #4099 , and I'm very grateful for this quick fix!
Then, when I used --incremental based on this fix, I reproduced the issue again.

Versions

Because vue-tsc based on the fixed version has not yet released a new version, I tested it after compiling the current latest [email protected] source code locally, where the dependencies are:

  • @volar/language-core : 2.2.0-alpha.3
  • @volar/typescript : 2.2.0-alpha.3

Steps to reproduce

  • I'm running vue-tsc via ./language-tools/packages/tsc/bin/vue-tsc.js --noEmit --incremental.
  • Local testing is required here, so it's also not convenient for me to provide a vue-tsc that can be tested directly, and I can try forking a repository later to reproduce the problem if needed.

  1. When vue-tsc --noEmit --incremental, the first execution (without tsconfig.tsbuildinfo), everything works fine and a new tsconfig.tsbuildinfo cache file is generated. As shown in the figure below:

    image

  2. Then, when executed repeatedly, the .ts file still prints the error as expected, but the .vue file no longer prints the source code for the error line. As shown in the figure below, the output error is incomplete.

    image

Also, with testing, I noticed that only .vue files will have incomplete errors, .ts files everything works fine.
@wangshunnn wangshunnn changed the title TypeScript errors not displayed in terminal with --incremental (vue-tsc@2) TypeScript errors are not displayed in terminal with --incremental (vue-tsc@2) Apr 2, 2024
wangshunnn added a commit to wangshunnn/volar.js that referenced this issue Apr 2, 2024
@wangshunnn
fix: vue-tsc does not show ts errors in the terminal with `--incremen…
a772447 
…tal`

refs vuejs/language-tools#4194
@wangshunnn wangshunnn mentioned this issue Apr 2, 2024
Merged
@johnsoncodehk johnsoncodehk added bug Something isn't working upstream good reproduction ✨ This issue provides a good reproduction, we will be able to investigate it first and removed pending triage labels Apr 4, 2024
johnsoncodehk added a commit to volarjs/volar.js that referenced this issue Apr 4, 2024
@wangshunnn @johnsoncodehk
fix: vue-tsc does not show ts errors in the terminal with `--incremen…
4c9b7cc 
…tal` (#158)

refs vuejs/language-tools#4194

---------

Co-authored-by: Johnson Chu <[email protected]>
@johnsoncodehk
Copy link
Member

Resolved by volarjs/volar.js#158

@wangshunnn wangshunnn mentioned this issue Apr 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good reproduction ✨ This issue provides a good reproduction, we will be able to investigate it first upstream
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@johnsoncodehk @wangshunnn