fix(typescript-plugin): fault tolerance for named pipe servers json f…

…ile (#4075)
vuejs · Mar 20, 2024 · 618a42c · 618a42c
1 parent bacea2a
commit 618a42c
Show file tree

Hide file tree

Showing 2 changed files with 30 additions and 17 deletions.
diff --git a/packages/typescript-plugin/lib/server.ts b/packages/typescript-plugin/lib/server.ts
@@ -5,7 +5,7 @@ import { collectExtractProps } from './requests/collectExtractProps';
 import { getComponentEvents, getComponentNames, getComponentProps, getElementAttrs, getTemplateContextProps } from './requests/componentInfos';
 import { getPropertiesAtLocation } from './requests/getPropertiesAtLocation';
 import { getQuickInfoAtPosition } from './requests/getQuickInfoAtPosition';
-import { NamedPipeServer, connect, pipeTable } from './utils';
+import { NamedPipeServer, connect, readPipeTable, updatePipeTable } from './utils';
 import type { FileRegistry, VueCompilerOptions } from '@vue/language-core';
 
 export interface Request {
@@ -103,16 +103,13 @@ export function startNamedPipeServer(
 
 	cleanupPipeTable();
 
-	if (!fs.existsSync(pipeTable)) {
-		fs.writeFileSync(pipeTable, JSON.stringify([] satisfies NamedPipeServer[]));
-	}
-	const table: NamedPipeServer[] = JSON.parse(fs.readFileSync(pipeTable, 'utf8'));
+	const table = readPipeTable();
 	table.push({
 		path: pipeFile,
 		serverKind,
 		currentDirectory,
 	});
-	fs.writeFileSync(pipeTable, JSON.stringify(table, undefined, 2));
+	updatePipeTable(table);
 
 	try {
 		fs.unlinkSync(pipeFile);
@@ -122,18 +119,15 @@ export function startNamedPipeServer(
 }
 
 function cleanupPipeTable() {
-	if (!fs.existsSync(pipeTable)) {
-		return;
-	}
-	for (const server of JSON.parse(fs.readFileSync(pipeTable, 'utf8'))) {
+	for (const server of readPipeTable()) {
 		connect(server.path).then(client => {
 			if (client) {
 				client.end();
 			}
 			else {
-				let table: NamedPipeServer[] = JSON.parse(fs.readFileSync(pipeTable, 'utf8'));
+				let table: NamedPipeServer[] = readPipeTable();
 				table = table.filter(item => item.path !== server.path);
-				fs.writeFileSync(pipeTable, JSON.stringify(table, undefined, 2));
+				updatePipeTable(table);
 			}
 		});
 	}

diff --git a/packages/typescript-plugin/lib/utils.ts b/packages/typescript-plugin/lib/utils.ts
@@ -13,7 +13,29 @@ export interface NamedPipeServer {
 
 const { version } = require('../package.json');
 
-export const pipeTable = path.join(os.tmpdir(), `vue-tsp-table-${version}.json`);
+const pipeTableFile = path.join(os.tmpdir(), `vue-tsp-table-${version}.json`);
+
+export function readPipeTable() {
+	if (!fs.existsSync(pipeTableFile)) {
+		return [];
+	}
+	try {
+		const servers: NamedPipeServer[] = JSON.parse(fs.readFileSync(pipeTableFile, 'utf8'));
+		return servers;
+	} catch {
+		fs.unlinkSync(pipeTableFile);
+		return [];
+	}
+}
+
+export function updatePipeTable(servers: NamedPipeServer[]) {
+	if (servers.length === 0) {
+		fs.unlinkSync(pipeTableFile);
+	}
+	else {
+		fs.writeFileSync(pipeTableFile, JSON.stringify(servers, undefined, 2));
+	}
+}
 
 export function connect(path: string) {
 	return new Promise<net.Socket | undefined>(resolve => {
@@ -28,10 +50,7 @@ export function connect(path: string) {
 }
 
 export async function searchNamedPipeServerForFile(fileName: string) {
-	if (!fs.existsSync(pipeTable)) {
-		return;
-	}
-	const servers: NamedPipeServer[] = JSON.parse(fs.readFileSync(pipeTable, 'utf8'));
+	const servers = readPipeTable();
 	const configuredServers = servers
 		.filter(item => item.serverKind === 1 satisfies ts.server.ProjectKind.Configured);
 	const inferredServers = servers