fix: avoid webview buttons show in unrelated extensions windows

close #1611
vuejs · Jul 31, 2022 · 5c13561 · 5c13561
1 parent 0c6e940
commit 5c13561
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 5 deletions.
diff --git a/extensions/vscode-vue-language-features/package.json b/extensions/vscode-vue-language-features/package.json
@@ -714,11 +714,11 @@
 				},
 				{
 					"command": "volar.action.selectElement",
-					"when": "activeEditor == WebviewEditor"
+					"when": "volarPreviewFocus"
 				},
 				{
 					"command": "volar.action.openInBrowser",
-					"when": "activeEditor == WebviewEditor"
+					"when": "volarPreviewFocus"
 				},
 				{
 					"command": "volar.selectTypeScriptVersion",
@@ -743,17 +743,17 @@
 				},
 				{
 					"command": "volar.action.selectElement",
-					"when": "activeEditor == WebviewEditor",
+					"when": "volarPreviewFocus",
 					"group": "navigation"
 				},
 				{
 					"command": "volar.action.openInBrowser",
-					"when": "activeEditor == WebviewEditor",
+					"when": "volarPreviewFocus",
 					"group": "navigation"
 				},
 				{
 					"command": "workbench.action.webview.reloadWebviewAction",
-					"when": "activeEditor == WebviewEditor",
+					"when": "volarPreviewFocus",
 					"group": "navigation"
 				}
 			],

diff --git a/extensions/vscode-vue-language-features/src/features/preview.ts b/extensions/vscode-vue-language-features/src/features/preview.ts
@@ -20,6 +20,7 @@ const enum PreviewType {
 export async function register(context: vscode.ExtensionContext) {
 
 	const panels = new Set<vscode.WebviewPanel>();
+	let _activePreview: vscode.WebviewPanel | undefined;
 	let externalBrowserPanel: vscode.WebviewPanel | undefined;
 	let avoidUpdateOnDidChangeActiveTextEditor = false;
 	let updateComponentPreview: Function | undefined;
@@ -365,6 +366,7 @@ export async function register(context: vscode.ExtensionContext) {
 				enableFindWidget: true,
 			},
 		);
+		trackActive();
 
 		const panelContext: vscode.Disposable[] = [];
 
@@ -412,6 +414,24 @@ export async function register(context: vscode.ExtensionContext) {
 		}
 
 		return port;
+
+		function trackActive(): void {
+			panel.onDidChangeViewState(({ webviewPanel }) => {
+				setPreviewActiveContext(webviewPanel.active);
+				_activePreview = webviewPanel.active ? panel : undefined;
+			});
+
+			panel.onDidDispose(() => {
+				if (_activePreview === panel) {
+					setPreviewActiveContext(false);
+					_activePreview = undefined;
+				}
+			});
+		}
+
+		function setPreviewActiveContext(value: boolean) {
+			vscode.commands.executeCommand('setContext', 'volarPreviewFocus', value);
+		}
 	}
 
 	async function webviewEventHandler(message: any) {