-
-
Notifications
You must be signed in to change notification settings - Fork 669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated rules #1881
Remove deprecated rules #1881
Conversation
The test fails because |
I wanted to discuss with you about removing the rule. |
Hmm, I tend to disagree here. Not removing deprecated rules might sound like it's making user's lives easier (since they don't have to make any changes when upgrading to the next major release), but I'd argue it's actually making it harder for users and maintainers:
Also, there will always be other breaking changes that require user action anyway, like changing a default option or dropping support for older Node versions etc. If users don't want breaking changes, they can still choose to not upgrade to new major versions. Then they will make the tradeoff "no maintenance for all rules" vs. "the configuration works as is" for themselves. That's why I think that deprecating a rule in a minor release and removing it in the next major release is a viable and fair strategy that saves time and work. |
Thank you for your opinion! I agree with you. Let us remove the deprecated rules. I think it's better to leave a document about the remove rules. I think maybe we need to move the list in the |
@ota-meshi I have added the rules docs back, and made clear in the docs that the rules are removed. Please see https://deploy-preview-1881--eslint-plugin-vue.netlify.app/rules/#removed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you very much
…eprecated # Conflicts: # docs/rules/README.md
Previously deprecated rules were removed completely:
vue/experimental-script-setup-vars
(deprecated in v7.13.0): not needed anymorevue/name-property-casing
(deprecated in v7.0.0): usevue/component-definition-name-casing
insteadvue/no-confusing-v-for-v-if
(deprecated in v5.0.0): usevue/no-use-v-if-with-v-for
insteadvue/no-unregistered-components
(deprecated in v8.4.0): usevue/no-undef-components
instead