Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compiler-core): Refs inside v-for are not applied through v-bind (fix #10696) #10706

Merged
merged 4 commits into from
Apr 22, 2024
Merged

fix(compiler-core): Refs inside v-for are not applied through v-bind (fix #10696) #10706

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ad64013
fix(compiler-core): Refs inside v-for are not applied through v-bind
Apr 15, 2024
9104300
refactor(compiler-core): add in buildProps an auxiliary variable hasVFor
Apr 18, 2024
88a4a30
[autofix.ci] apply automated fixes
autofix-ci[bot] Apr 22, 2024
5cce191
refactor: extract pushRefVForMarker + tests
yyx990803 Apr 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions packages/compiler-core/src/transforms/transformElement.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -615,6 +615,14 @@ export function buildProps(
hasDynamicKeys = true
if (exp) {
if (isVBind) {
// if in v-bind object will have a ref we should set ref_for to true
// otherwise the ref will be set to a random element in the list
if (context.scopes.vFor > 0) properties.push(
createObjectProperty(
createSimpleExpression('ref_for', true),
createSimpleExpression('true'),
),
)
// have to merge early for compat build check
pushMergeArg()
if (__COMPAT__) {
Expand Down