v4: Fix useResult type inferring 'any' #872
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
useResult
is great for reactive objects, but the unwrapped type is currently inferred asany
. This results in unnecessary and unsafe casting. The type information is available to be inferred, but theuseResult
function is not using it.This PR fixes the issue by providing stricter type inference to
useResult
andcomputed
for thedefaultValue
andpick
return values, which results in correct typing.Issue
Usage:
❌ Typed as
const project: Readonly<Ref<Readonly<any>>>
PR Fix
Usage:
✅ Typed as
const project: Readonly<Ref<Readonly<Project> | Readonly<{}>>>
✅ Typed as
const project: Readonly<Ref<Readonly<Project> | undefined>>