Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Preact doc #1596

Merged
merged 3 commits into from
Nov 25, 2024
Merged

Fix Preact doc #1596

merged 3 commits into from
Nov 25, 2024

Conversation

mariana-caetano
Copy link
Contributor

Types of changes

  • New content (guides, endpoints, app documentation)
  • Improvement (make a documentation even better)
  • Fix (fix a documentation error)
  • Spelling and grammar accuracy (self-explanatory)

@mariana-caetano mariana-caetano self-assigned this Nov 25, 2024
Copy link
Contributor

Navigation Preview Link

No changes detected in the navigation.json file

Copy link
Contributor

Preview Links

Open this URL to set up the portal with this branch changes.

You can now access the edited pages with the following URLs:

2. Go to `faststore.config.js` file and add the `preact` flag in the `experimental` section:
2. Go to `discovery.config.js` file and add the `preact` flag in the `experimental` section:

> The `faststore.config.js` file is the legacy filename for `discovery.config.js`. If you still using the legacy name, please refer to [this release note]() to update it.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mariana-caetano we don't have a release note on the portal related to this issue yet, right?
We have this one in GH: https://github.com/vtex/faststore/releases/tag/v3.0.123

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hellofanny not yet, I've created this draft release: https://docs.google.com/document/d/18yZpW9Kf2QqU3EeNxDdPCBFAjhfLv-TSp83ezl556hg/edit?tab=t.0

Feel free to comment on this, I also left some questions on there.

Copy link
Contributor Author

@mariana-caetano mariana-caetano Nov 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hellofanny, for now, I'll add the release note from GitHub, but once we have the draft ready, I'll update the doc.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay!! Thank you!

@mariana-caetano mariana-caetano marked this pull request as ready for review November 25, 2024 17:01
@mariana-caetano mariana-caetano changed the title Update Preact doc Fix Preact doc Nov 25, 2024
@mariana-caetano mariana-caetano merged commit 3f78f45 into main Nov 25, 2024
6 checks passed
@mariana-caetano mariana-caetano deleted the preact-review branch November 25, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants