Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/twitter meta tags #408

Merged
merged 8 commits into from
Dec 14, 2021

Conversation

edyespinal
Copy link
Contributor

What problem is this solving?

This PR adds the messages to a store's settings for the Twitter Meta Tags app configuration.

How should this be manually tested?

The app is linked in this workspace.
You can see the messages on the different available languages for the Twitter Meta Tags app configuration.

Screenshots or example usage

Screen.Recording.2021-09-02.at.12.39.18-1.mov

Type of changes

✔️ Type of Change
_ Bug fix
_ New feature
_ Breaking change
_ Technical improvements

@vtex-io-ci-cd
Copy link
Contributor

vtex-io-ci-cd bot commented Sep 2, 2021

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@vtex-io-docs-bot
Copy link

vtex-io-docs-bot bot commented Sep 2, 2021

Beep boop 🤖

I noticed you didn't make any changes at the docs/ folder

  • There's nothing new to document 🤔
  • I'll do it later 😞

In order to keep track, I'll create an issue if you decide now is not a good time

  • I just updated 🎉🎉

@edyespinal
Copy link
Contributor Author

@vtex-apps/store-framework-devs

@lariciamota lariciamota requested a review from a team September 27, 2021 18:13
@davicostalf
Copy link

davicostalf commented Sep 28, 2021

  • Instead of including this as an instruction, we should support usernames written both with and without the @.
    image

  • This Select should have a label, maybe "Twitter card type".
    image

  • Also, please rename the options to follow the name in Twitter's documentation: "Summary" and "Summary with Large Image". What card does the "Photo" option show?
    image

@edyespinal
Copy link
Contributor Author

Hi @davicostalf 👋🏼
Thanks for the comments!
Will take this into consideration for the PR to the vtex-apps/store.
However, this PR is only for adding translations for the messages displayed to the user.

@davicostalf
Copy link

Hi @davicostalf 👋🏼 Thanks for the comments! Will take this into consideration for the PR to the vtex-apps/store. However, this PR is only for adding translations for the messages displayed to the user.

Thanks. Please send me this other PR in Slack when you have it.
Also, I think these new messages need to be sent to the localization team so they can review and include them in all languages.

@edyespinal
Copy link
Contributor Author

Thanks. Please send me this other PR in Slack when you have it. Also, I think these new messages need to be sent to the localization team so they can review and include them in all languages.

Hi @davicostalf
This is the PR to vtex-apps/store.

For this PR the only thing we need is the Localization team translations right?

@mateuspontes
Copy link
Contributor

@edyespinal do you have any updates about the Localization Team?

@edyespinal
Copy link
Contributor Author

edyespinal commented Oct 20, 2021

@edyespinal do you have any updates about the Localization Team?

@mateuspontes yes. I forgot to comment to let you know.
All the changes have been pushed as well as you can see in the commit history above. 👆🏼

@edyespinal
Copy link
Contributor Author

@felippenardi
Any updates for this PR?

@mateuspontes mateuspontes merged commit 5a61096 into vtex-apps:master Dec 14, 2021
@vtex-io-ci-cd
Copy link
Contributor

vtex-io-ci-cd bot commented Dec 14, 2021

Your PR has been merged! App is being published. 🚀
Version 4.46.0 → 4.46.1

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy [email protected]

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. 📖

@edyespinal edyespinal deleted the feat/twitter-meta-tags branch December 14, 2021 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants