Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add mobile support #78

Merged
merged 5 commits into from
Oct 16, 2022
Merged

Add mobile support #78

merged 5 commits into from
Oct 16, 2022

Conversation

Fyzu
Copy link
Contributor

@Fyzu Fyzu commented Oct 13, 2022

Mobile support 🎉

@Fyzu
Copy link
Contributor Author

Fyzu commented Oct 13, 2022

@vslinko can you look at it?

@vslinko
Copy link
Owner

vslinko commented Oct 13, 2022

@Fyzu thank you for the contribution!

please, remove unused icons here https://github.com/vslinko/obsidian-zoom/pull/78/files#diff-d16a4f4364ebadbdedd141c31462980fa181f1cf849adf13e3f2d031519c7a76L16-L23

@vslinko
Copy link
Owner

vslinko commented Oct 13, 2022

@Fyzu also I think ZoomOnClickFeature should be disabled on mobile devices, it's very annoying. or it could be configurable and disabled by default.

@Fyzu
Copy link
Contributor Author

Fyzu commented Oct 14, 2022

@vslinko done

vslinko
vslinko requested changes Oct 14, 2022
View reviewed changes
src/services/SettingsService.ts Outdated Show resolved Hide resolved
@vslinko vslinko merged commit 246c921 into vslinko:main Oct 16, 2022
@Fyzu Fyzu mentioned this pull request Oct 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vslinko vslinko vslinko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Fyzu @vslinko