Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reveal TagFolder view after clicking a tag #95

Merged
merged 2 commits into from
Jan 31, 2024

Conversation

RyotaUshio
Copy link
Contributor

@RyotaUshio RyotaUshio commented Dec 31, 2023

Thank you so much for this awesome plugin, and a happy new year!

I've noticed that when I turn on the Search tags inside TagFolder when clicking tags option and click a tag in a markdown view, it doesn't automatically open the left sidebar (and hence the TagFolder view).

If the left sidebar is hidden at first, it even looks like nothing happened, which can be confusing for some users.

The option is meant to override the default behavior where clicking a tag opens the core search view in the sidebar. So I think it would be more user-friendly if this option behaved the same.

If this is intentional, please let me know. I can add a setting to choose whether the left sidebar should be opened or not. Thank you!

@vrtmrz
Copy link
Owner

vrtmrz commented Jan 31, 2024

Thank you for the PR! I am verry happy to merge it within the new year's month!
I approve this PR and appreciate your contributions!

@vrtmrz vrtmrz merged commit 95e8055 into vrtmrz:main Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants