chore(cicd): adds workflow to run checks on push to main and pull-reqs #537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pe-assertion ... as the extra asserts in this code base seem more useful My personal preference is to be explicit with typing and this eslint check is counter to that. Also in the areas where this linting error are triggered it seems useful to have the type asserts as they help code-clarity
… push and PRs This should help ensure the code-quality stays as good as it already is, and/or improve it over time.
This helps fix a gotcha for future contributors.
This will get the workflow running without code-infra errors, but it will not pass linting, yet.
doublethefish
changed the title
|
For the workflow checks to pass we will require vrtmrz/livesync-commonlib#7 to be accepted upstream, and the git-submodule updated with that change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This configures the submodule and runs
npm run checkon the code.This is a first-pass of getting the checks working before I make any other changes, and help me ensure I don't break the project.