Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is currently a work in progress commit.
I'm making a draft pull request to get your feedback on the feature and its implementation.
The idea of this pull request to improve the user experience of the "Skip patterns" setting by providing more types of patterns, a better user interface for editing the patterns, and visual feedback to know if patterns are working.
New Features:
❌ --> Invalid pattern
✅ --> Valid pattern
*
matches everything except directories**
matches directories{a,b}
matches eithera
orb
{a}
is invalid, so it literally matches{a}
.Fixed:
syncInternalFilesIgnorePatterns
(Skip patterns) does not work for patterns with uppercase characters. #168Done
To-Do
PatternSetSetting
to use lessdata-
attributes.syncInternalFilesIgnorePatterns
(Skip patterns) does not work for patterns with uppercase characters. #168(?i)
at the start of the pattern => case insensitive (default)(?-i)
at the start of the pattern => case sensitive