Add Rails 6 support #329
Merged
Add Rails 6 support #329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also bumping the version of sqlite3, as AR 6 requires ~> 1.4
Slightly annoying, but I miss simple navigation in my debugger..
After each test, we teardown the in-memory AR DB/cache classes so we can start with a fresh AR object graph. AR 6 changed some of the internals (rails/rails@1b2efe5) around detecting what should be unloaded when ActiveSupport::DescendantsTracker#clear is called; this is the danger on relying on internals! This little hack manually removes the ActiveRecord::Base descendants from the class variable that tracks what's loaded and what isn't; It will probably live on for years.
kerrizor
force-pushed
the
kerrizor/add-rails-6-support
branch
from
32c2942 to
77a2c9f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Rails 6 testing, but official support is still considered experimental until an official 6.0.0 release.