Remove identifier from association_identity #327
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By removing the identifier, we're removing duplicates but increasing the weight.
Taking a look at the
rake examples
output for the "spree" application, we see that theAddress
model has:which,
<master>
generates (inoutput/spree.dot
):With this change, our output DOT shows this as:
I'm a bit nervous about this change; what I think I might prefer is to see an option for labelling relationships, either all of them, or when there are multiples like this that have different
:foreign_key
declarations, but it isn't a huge priority, something for a future release. For now, this solves the problems reported by many, many users.Rebase of #296
See #70 (comment)
Fixes #278
(h/t to @afn who submitted the PR originally)