Drop support for Rails 3.2 -> 4.0, Run tests for Rails 5.1 + 5.2 #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kerrizor
force-pushed
the
pr-306
branch
2 times, most recently
from
b5c48b3 to
a1d4eae
Compare
address couple of warnings
Original work date
From: Wed Sep 26 11:25:43 2018 +0900
To: Thu Sep 27 08:52:36 2018 +0900
remove old rails and rubies
kerrizor
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copy of #306 that addresses :travis: test failures, which really just needed a rebase and some cherry-picking, the original contribution was 👩🍳👌