-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small fixes in T021 #153
Small fixes in T021 #153
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@t-kimber looks great. Thanks for the detailed update.
Ready to be merged!
Great, thanks @AndreaVolkamer ! @dominiquesydow, can you just confirm that the tests that are failing are still okay to be merged on master or am I breaking something which is passing on master? |
Could you please re-generate the READMEs with
The Windows fail is odd, it does not say why. I will check it again when the README pushs triggered rerunning the CI. |
@t-kimber, I think you can merge this now :) The "This check failed" problem under Windows could be temporary from GHA's side
The Docs fail due to "broken" links that are not broken... Will open an issue to address all this separately :) |
This PR fixes small things in T021:
Note:
I still think that we should remove the suppl. material in this notebook.
Status