Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Platform] More consistent entrypoints across different platforms #11448

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

terrytangyuan
Copy link
Contributor

This PR makes the entrypoint consistent across different platforms. Previously both /bin/bash are apiserver are used.

Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@DarkLight1337
Copy link
Member

IIRC the entrypoint is kept this way on purpose for ROCm. cc @hongxiayang

@terrytangyuan
Copy link
Contributor Author

terrytangyuan commented Dec 24, 2024

I'd love to understand the rationale behind this. IMO we should have consistent default behavior. This can be overridden at container execution time anyways.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants