Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] Fix issues in CPU build Dockerfile. Fixes #9182 #11435

Merged
merged 2 commits into from
Dec 24, 2024

Conversation

terrytangyuan
Copy link
Contributor

@terrytangyuan terrytangyuan commented Dec 23, 2024

Fixes #9182. This fixes the following two issues. Verified that build is successful after these changes.

Issue 1:

ERROR: Could not open requirements file: [Errno 13] Permission denied: 'requirements-build.txt'

Issue 2:

LookupError: setuptools-scm was unable to detect version for /workspace/vllm

Related issues #9182 and #8502

Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@mergify mergify bot added the ci/build label Dec 23, 2024
@DarkLight1337
Copy link
Member

cc @dtrifiro

@terrytangyuan
Copy link
Contributor Author

@dtrifiro is on vacation

@DarkLight1337
Copy link
Member

I see, thanks for the heads up!

@DarkLight1337
Copy link
Member

Can you add a TODO that links to #9182 (comment) so we might come up with a better solution in the future?

@DarkLight1337
Copy link
Member

Also, maybe we can mark this PR as fixing #9182?

@terrytangyuan terrytangyuan changed the title Fix issues in CPU build Dockerfile [Bugfix] Fix issues in CPU build Dockerfile. Fixes #9182 Dec 23, 2024
@terrytangyuan
Copy link
Contributor Author

Updated. Thanks!

Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now, thanks for fixing!

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) December 23, 2024 15:37
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Dec 23, 2024
@terrytangyuan
Copy link
Contributor Author

Looks like build failure may not be related since ppc64le is failing but I didn't modify Dockerfile.ppc64le.

@DarkLight1337
Copy link
Member

Can you merge from main? It should fix the CI failures.

auto-merge was automatically disabled December 24, 2024 11:16

Head branch was pushed to by a user without write access

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) December 24, 2024 11:16
@terrytangyuan
Copy link
Contributor Author

Looks like it's still failing.

@DarkLight1337
Copy link
Member

Retrying the test...

@DarkLight1337 DarkLight1337 merged commit 409475a into vllm-project:main Dec 24, 2024
76 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/build ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
2 participants