-
-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bugfix] Fix issues in CPU build Dockerfile. Fixes #9182 #11435
Conversation
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can do one of these:
🚀 |
cc @dtrifiro |
@dtrifiro is on vacation |
I see, thanks for the heads up! |
Can you add a TODO that links to #9182 (comment) so we might come up with a better solution in the future? |
Also, maybe we can mark this PR as fixing #9182? |
Updated. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now, thanks for fixing!
Looks like build failure may not be related since ppc64le is failing but I didn't modify |
Can you merge from main? It should fix the CI failures. |
Signed-off-by: Yuan Tang <[email protected]>
Signed-off-by: Yuan Tang <[email protected]>
Head branch was pushed to by a user without write access
d6bf96c
to
61a2d89
Compare
Looks like it's still failing. |
Retrying the test... |
Fixes #9182. This fixes the following two issues. Verified that build is successful after these changes.
Issue 1:
Issue 2:
Related issues #9182 and #8502