Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing bos_token to example templates #11432

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

toslunar
Copy link
Contributor

@toslunar toslunar commented Dec 23, 2024

This PR updates chat template examples to align with the latest (>=0.4.3) /v1/chat/completions spec on BOS.

Some chat templates don't contain bos_token, especially when it's written before v0.4.3. According to the excellent investigation #9519, the chat serving does not add BOS again, while awkwardness remains in the offline chat interface (to be fixed).

Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@DarkLight1337
Copy link
Member

Thanks for fixing, can you add some unit tests to ensure that the BOS token isn't added twice in this case?

@toslunar
Copy link
Contributor Author

Added a test.

Is it OK to place it to a new directory (tests/examples_tests) because it seems the first time to test files in examples? I named it examples_tests because it shouldn't be confused with data directories like tests/data and tests/prompts.

@DarkLight1337
Copy link
Member

I would just name the directory tests/examples. Can you add the tests to CI by editing this file?

Signed-off-by: Toshiki Kataoka <[email protected]>
Signed-off-by: Toshiki Kataoka <[email protected]>
@mergify mergify bot added the ci/build label Dec 24, 2024
Comment on lines +206 to +212
- label: Examples Unit Test
working_dir: "/vllm-workspace/tests"
source_file_dependencies:
- tests/examples/
- examples/
commands:
- pytest -v -s examples
Copy link
Member

@DarkLight1337 DarkLight1337 Dec 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge this with the existing Examples Test to avoid starting a new instance just for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants