Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TTFT to offline_inference_with_prefix.py #11428

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

xu-song
Copy link

@xu-song xu-song commented Dec 23, 2024

TTFT is an important metric for prefix cache

Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@comaniac
Copy link
Collaborator

TTFT is not usually used in offline inference which cares more about throughput than latency.

@xu-song
Copy link
Author

xu-song commented Dec 23, 2024

As I know, the throughput benefit mainly comes from TTFT in prefilling period, not token/s in decoding period. Is that right?

@comaniac
Copy link
Collaborator

Yes but that's not my point. TTFT is only meaningful in online serving with streaming output. In offline inference, we don't output responses token by token, so we usually rely on end to end throughput or "input (prefill)" throughput as metrics. If you want know see the TTFT improvements with prefix caching, we also have a serving benchmark for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants