[Model][BugFix] Mamba/Jamba exceed mamba cache slots #11414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
causing an error inside the mamba cache manager, setting the max num seqs as twice as the max batch size, ensures that new requests will have spare space in the mamba cache manager Signed-off-by: mzusman <[email protected]>
Signed-off-by: mzusman <[email protected]>
Signed-off-by: mzusman <[email protected]>
|
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can do one of these:
🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In recent vLLM versions (since v0.6.4) running requests are not capped anymore by
scheduler_config.max_num_seqswhich causes an issue on Jamba/Mamba models on high loads.Mamba models keeps a state inside the modeling file and defines the max running sequences/slots as
max_num_seqs. exceeding this number of slots causes an error that crashes vLLM.to solve that, I've introduced an envar that multiplies the mamba cache slots by a certain amount (x1.5 by default) .
The default is x1.5 as I've seen it's quite sufficient in my tests.
CC @tlrmchlsmth