Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Fix hermes tool parser output error stream arguments in some cases #10396

Closed
wants to merge 1 commit into from

Conversation

xiyuan-lee
Copy link
Contributor

[BugFix] Fix hermes tool parser output error stream arguments in some cases (#10395)

Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@xiyuan-lee xiyuan-lee changed the title [BugFix] Fix hermes tool parser output error stream arguments in some cases ([#10395](https://github.com/vllm-project/vllm/issues/10395)) [BugFix] Fix hermes tool parser output error stream arguments in some cases (#10395) Nov 16, 2024
@xiyuan-lee xiyuan-lee changed the title [BugFix] Fix hermes tool parser output error stream arguments in some cases (#10395) [BugFix] Fix hermes tool parser output error stream arguments in some cases Nov 16, 2024
@mergify mergify bot added the frontend label Nov 16, 2024
@xiyuan-lee xiyuan-lee marked this pull request as draft November 16, 2024 17:31
@xiyuan-lee xiyuan-lee closed this Nov 16, 2024
@xiyuan-lee xiyuan-lee reopened this Nov 16, 2024
@xiyuan-lee xiyuan-lee marked this pull request as ready for review November 16, 2024 17:31
@xiyuan-lee xiyuan-lee closed this Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant