Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[plugin-web-app] Add step to download files from Chrome downloa… #5032

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[plugin-web-app] Add step to download files from Chrome downloa… #5032

wants to merge 1 commit into from

Conversation

vkepin
Copy link
Contributor

@vkepin vkepin commented May 8, 2024

…ds page

@vkepin vkepin marked this pull request as ready for review May 8, 2024 10:40
@vkepin vkepin requested a review from a team as a code owner May 8, 2024 10:40
@vkepin vkepin requested review from valfirst, uarlouski and draker94 May 8, 2024 10:40
@vkepin vkepin changed the title [plugin-web-app] [WIP] Add step to download files from Chrome downloa… [plugin-web-app] Add step to download files from Chrome downloa… May 8, 2024
@vkepin vkepin force-pushed the chrome_download branch from 63a695e to 2c9be62 Compare May 10, 2024 07:59
@codecov Codecov
Copy link

codecov bot commented May 10, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 97.56098% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 97.40%. Comparing base (c428655) to head (b4cca11).
Report is 1 commits behind head on master.

Files Patch % Lines
.../vividus/steps/ui/web/ChromeExperimentalSteps.java 97.56% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff            @@
##             master    #5032   +/-   ##
=========================================
  Coverage     97.40%   97.40%           
- Complexity     6628     6639   +11     
=========================================
  Files           921      922    +1     
  Lines         19190    19231   +41     
  Branches       1270     1273    +3     
=========================================
+ Hits          18692    18732   +40     
- Misses          389      390    +1     
  Partials        109      109

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vkepin vkepin force-pushed the chrome_download branch from 2c9be62 to b97add8 Compare May 10, 2024 09:38
@vkepin vkepin force-pushed the chrome_download branch from b97add8 to b4cca11 Compare May 10, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valfirst valfirst Awaiting requested review from valfirst valfirst is a code owner automatically assigned from vividus-framework/maintainers

@uarlouski uarlouski Awaiting requested review from uarlouski uarlouski is a code owner automatically assigned from vividus-framework/maintainers

@draker94 draker94 Awaiting requested review from draker94 draker94 is a code owner automatically assigned from vividus-framework/maintainers

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@vkepin