[engine] Use pretty logging when saving maps and lists #3799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed! |
Codecov Report
@@ Coverage Diff @@
## master #3799 +/- ##
============================================
- Coverage 96.99% 96.99% -0.01%
- Complexity 6083 6086 +3
============================================
Files 851 851
Lines 17449 17452 +3
Branches 1134 1134
============================================
+ Hits 16925 16927 +2
- Misses 418 419 +1
Partials 106 106
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
valfirst
reviewed
Apr 4, 2023
| @@ -69,7 +73,9 @@ public void putVariable(VariableScope variableScope, String variableKey, Object | |||
| else | |||
| { | |||
| LOGGER.atInfo() | |||
| .addArgument(variableValue) | |||
| .addArgument(() -> variableValue instanceof Map || variableValue instanceof Collection | |||
| ? jsonUtils.toPrettyJson(variableValue) | |||
There was a problem hiding this comment.
we shouldn't convert collections to JSON-s
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.