fix(vite-node): top-level throw in module is not reported properly

[vanaigr]

Description

A throw statement in a watched module can sometimes cause vite-node itself to crash (when trying to report that error), leading to the original error being lost.

Here is an example of this happening:
https://stackblitz.com/edit/vitest-dev-vitest-agi4oq?file=basic.ts

If you edit the file after the ready message is printed, vite-node will print the following error:

[vite-node] Failed to execute file: 
 TypeError: Cannot read properties of undefined (reading 'match')
    at warnFailedFetch (file:///home/projects/vitest-dev-vitest-agi4oq/node_modules/vite-node/dist/chunk-hmr.mjs:149:20)
    at fetchUpdate (file:///home/projects/vitest-dev-vitest-agi4oq/node_modules/vite-node/dist/chunk-hmr.mjs:137:7)
    at async queueUpdate (file:///home/projects/vitest-dev-vitest-agi4oq/node_modules/vite-node/dist/chunk-hmr.mjs:113:6)
    at async Module.handleMessage (file:///home/projects/vitest-dev-vitest-agi4oq/node_modules/vite-node/dist/chunk-hmr.mjs:164:7)

Explanation

This happens when a module is reloaded and throws something that is not an Error, e.g. a string.

This error propagates from runModule()

vitest/packages/vite-node/src/client.ts

Lines 508 to 510 in 1a8d670

	const fn = vm.runInThisContext(code, options)
	await fn(...Object.values(context))
	}

to warnFailedFetch(), where it fails at line 164 when it tries to call match on a non-existing message property of a string:

vitest/packages/vite-node/src/hmr/hmr.ts

Lines 163 to 166 in 1a8d670

	function warnFailedFetch(err: Error, path: string | string[]) {
	if (!err.message.match('fetch')) {
	console.error(err)
	}

Solution

The easiest solution is to check if the error is actually an Error when printing before reading the message property.

I thought of wrapping the thrown object in an Error with cause in runModule(), but that would change how the error message is shown (since now the message and stacktrace would be from that error and not the original error).

[vanaigr]

Accidentally used main instead of the feature branch

[hi-ogawa]

Looks good! Just left a minor suggestion.

[netlify]

✅ Deploy Preview for vitest-dev ready!

Built without sensitive environment variables

Name	Link
🔨 Latest commit	1b0e0e5
🔍 Latest deploy log	https://app.netlify.com/sites/vitest-dev/deploys/672832e2f6aa740008d80b2f
😎 Deploy Preview	https://deploy-preview-6840--vitest-dev.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.