Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle sourcemap correctly when multiple line import exists #14232

Merged
merged 2 commits into from
Aug 29, 2023
Merged

fix: handle sourcemap correctly when multiple line import exists #14232

merged 2 commits into from
Aug 29, 2023

Conversation

sapphi-red
Copy link
Member

Description

Before: sourcemap visualizer
After: sourcemap visualizer

fixes #14109

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added p3-minor-bug An edge case that only affects very specific usage (priority) feat: sourcemap Sourcemap support labels Aug 29, 2023
@stackblitz
Copy link

stackblitz bot commented Aug 29, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@patak-dev patak-dev merged commit 627159d into vitejs:main Aug 29, 2023
@sapphi-red sapphi-red deleted the fix/broken-sourcemap-with-multiple-line-imports branch August 30, 2023 08:29
bluwy pushed a commit that referenced this pull request Oct 3, 2023
@sapphi-red @bluwy
fix: handle sourcemap correctly when multiple line import exists (#14232
8c35aad 
)
@bluwy bluwy mentioned this pull request Oct 3, 2023
Merged
bluwy pushed a commit that referenced this pull request Oct 3, 2023
@sapphi-red @bluwy
fix: handle sourcemap correctly when multiple line import exists (#14232
218861f 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patak-dev patak-dev patak-dev approved these changes

Assignees
No one assigned
Labels
feat: sourcemap Sourcemap support p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Broken sourcemap
2 participants
@sapphi-red @patak-dev