Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Depreciated Package Content #42

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

webbrandon
Copy link

  • node-uuid 1.4.7 => uuid 3.0.0
  • License requires SPDX string now.

Brandon Clark added 2 commits November 22, 2016 11:38
- `node-uuid 1.4.7` => `uuid 3.0.0`
- License requires SPDX string now.
@@ -42,5 +42,5 @@
"Ognian Tschakalov <[email protected]>",
"Simon Wade <[email protected]>"
],
"license": "BSD"
"license": "BSD-3-Clause"
Copy link
Collaborator

@marcbachmann marcbachmann Dec 1, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The BSD license is the 4-Clause license: https://en.wikipedia.org/wiki/BSD_licenses#4-clause_license_.28original_.22BSD_License.22.29

So we can't just change the license like that. We have to contact @villadora to do that (maybe we can change it to another license right away).

I'll accept a pr with the change to BSD-4-Clause.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would probably be a good thing for @villadora to weigh in on, especially considering that they are mostly hands off of this lib at this point. The 4-Clause requires attribution (which I doubt most people follow). The 3-Clause is an OSI approved license and would simplify things for users while still maintaining the same licensing protections.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants