Feat/networth sessions #863
Conversation
…en snapshots and different mode
…en snapshots and different mode
| "income_based_on_last_inactive_tooltip_short": "Since last inactivity", | ||
| "income_based_on_last_hour_tooltip_short": "Since last hour", | ||
| "critial_stashtyp_unique_tooltip": "Attention, a separate request is made for each item in the unique stashtab. This can significantly increase snapshot duration.", | ||
| "critial_stashtyp_map_tooltip": "Attention, spearate requests are made for all tiles in the map stash tab, which are not atlas maps. This can significantly increase snapshot duration.", |
There was a problem hiding this comment.
| "critial_stashtyp_map_tooltip": "Attention, spearate requests are made for all tiles in the map stash tab, which are not atlas maps. This can significantly increase snapshot duration.", | |
| "critical_stashtype_map_tooltip": "Separate requests are made for every map in the map stash tab. This can significantly increase snapshot duration.", |
There was a problem hiding this comment.
I think it's for all unique and special maps. Normal maps cannot be requested since the introduction of the map stash tab.
Maybe we should write "for every non standard map"
There was a problem hiding this comment.
| "critial_stashtyp_map_tooltip": "Attention, spearate requests are made for all tiles in the map stash tab, which are not atlas maps. This can significantly increase snapshot duration.", | |
| "critical_stashtype_map_tooltip": "Separate requests are made for every non standard map in the map stash tab. This can significantly increase snapshot duration.", |
ExilenceNextApp/src/components/item-table/ItemTableContainer.tsx
Outdated
Show resolved
Hide resolved
ExilenceNextApp/src/components/manual-adjustment-dialog/ManualAdjustmentDialogDialog.tsx
Outdated
Show resolved
Hide resolved
| setTimeout(() => { | ||
| electronService.ipcRenderer.send('closed'); | ||
| // TODO: If closed to early, the states are not saved to indexDB; Is there any hook/callback? | ||
| }, 1000); |
There was a problem hiding this comment.
may need to add clearTimeout somewhere to avoid edge-case memory leaks
There was a problem hiding this comment.
This shoudn't be cleared, because this is a callback for the app "close" event. If the timeout does not trigger the ipcRenderer event, then the app fails to exit.
ExilenceNextApp/src/types/net-worth-session-income-mode.type.ts
Outdated
Show resolved
Hide resolved
ExilenceNextApp/src/components/stash-tab-dropdown/StashTabDropdown.tsx
Outdated
Show resolved
Hide resolved
| () => [ | ||
| { | ||
| type: 'MapStash', | ||
| message: t('common:label.critial_stashtyp_map_tooltip'), |
There was a problem hiding this comment.
| message: t('common:label.critial_stashtyp_map_tooltip'), | |
| message: t('common:label.critical_stashtype_map_tooltip'), |
ExilenceNextApp/src/components/chart-accordions/NetWorthChartAccordion.tsx
Outdated
Show resolved
Hide resolved
ExilenceNextApp/src/components/chart-accordions/NetWorthChartAccordion.tsx
Outdated
Show resolved
Hide resolved
ExilenceNextApp/src/components/chart-accordions/NetWorthTabChartAccordion.tsx
Outdated
Show resolved
Hide resolved
ExilenceNextApp/src/components/chart-accordions/SessionTimeChartAccordion.tsx
Outdated
Show resolved
Hide resolved
ExilenceNextApp/src/components/chart-accordions/SessionTimePieChartAccordion.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Sebastian Krzyżanowski <[email protected]>
Co-authored-by: Sebastian Krzyżanowski <[email protected]>
Co-authored-by: Sebastian Krzyżanowski <[email protected]>
Co-authored-by: Sebastian Krzyżanowski <[email protected]>
|
@sbsrnt I accepted all of your suggestions. For the ones I didn't take over, this has a reason or still needs to be clarified. |
Co-authored-by: Sebastian Krzyżanowski <[email protected]>
|
Appreciate the effort to make the tool better, unfortunately ultimately everything has been shut down 😿 |
|
Yeah, but its already merged into https://github.com/exilence-ce/exilence-ce :) I took the pr over. We will release this the next days. Anyways thanks for the code review. |
|
Exilence will also be integrated into poestack-sage as plugin |
|
This is due all the missing items poe ninja are missing. That are many! |
Hello @viktorgullmark,
as discussed I will send you the pull request.
This pull request contains:
Other fixes:
FIXED: Networth overlay does not shows the currency in divine/ex when opened
FIXED: Networth overlay does sometimes not update the states/is not in sync with the app
FIXED: Wrong Time format for minutes(currently as month formated after hour): HH:MM => HH:mm
Other features:
Added: Add critical stash tabs with tooltip info for profile selection
Added to the base UI:
TODOs:
I'll pass on the color selection to you. Its defined in the theme.
Stepper optimizations?