-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Improve off-reference coordinate and rGFA support #3891
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The overall goal here is to allow calling within large insertions: With the HPRC human pangenomes, we presently project to hg38 using
vg surject
for Giraffe/DeepVariant or vg's VCF projection fordeconstruct
andcall
. In all cases, this makes looking at variants within insertions difficult: they could be lost insurject
or get buried in giant nested alleles in VCF.As far as the vg tools are concerned, we could support variants within insertions provided they get unique "reference' paths to project on. rGFA is what minigraph uses to define these paths: each node in the graph gets a "stable" coordinate on one of the input haplotypes. This is effectively a path cover of the graph that gives each position a unique coordinate.
There are some challenges with incorporating this into vg:
As of right now, this PR adds an option to
vg paths
to compute the rGFA cover using a greedy algorithm, allowing specification of a minimum fragment size. This is nearly enough to start playing around with some applications. But there's still work to be done on the metadata questions above before it can be merged.