add source package support #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Vincent, this looks great! Can you add tests to verify that this works as expected? |
vincent178
force-pushed
the
srv-pkg-support
branch
from
8d22b20 to
421d0ed
Compare
|
Hi @LandonTClipp , PTAL |
|
@vincent178 according to the go/loader docs, it is deprecated: https://godoc.org/golang.org/x/tools/go/loader Can we use |
vincent178
force-pushed
the
srv-pkg-support
branch
from
421d0ed to
df49f7c
Compare
|
@LandonTClipp good catch, it's interesting that I tested |
* add srcpkg flag pass in external package import path * use golang.org/x/tools/go/packages parse package * add unit tests and integration tests
vincent178
force-pushed
the
srv-pkg-support
branch
from
df49f7c to
aabaa30
Compare
|
Looks good to me. I was about to ask you to to add more unit tests but it looks like those don't really exist for main. This'll be something I'll fix in v2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Vincent Huang [email protected]
Background
There's a usecase we want to generate mock for external package, there's one solution in community #210 (comment), but it's not clean to specify another alias interface into my codebase. The other solution is using
-dirlike in this #210 (comment) but it requires some knowledge to use it right, like it's different under go module and$GOPATH.With this change, we can generate an external package mock anywhere (with go.mod or under $GOPATH) with
Changes
srcpkgsrcpkg, read directory and setBaseDirto itTest