Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH Actions CI Additions + Linter fixups #242

Merged
merged 6 commits into from
Sep 14, 2022
Merged

GH Actions CI Additions + Linter fixups #242

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8064f29
Add basic PR CI/CD checks.
philipaconrad Sep 14, 2022
b8f0eac
Linter ignores for dot imports.
philipaconrad Sep 14, 2022
7007f8c
Fix linter issues with changes + ignores.
philipaconrad Sep 14, 2022
ffc8b42
Fix prealloc linter suggestions.
philipaconrad Sep 14, 2022
b7c1b8b
Switch to `ubuntu-latest` + use GH Action for golangci-lint.
philipaconrad Sep 14, 2022
dbf63af
Disable MacOS tests.
philipaconrad Sep 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/manual-go-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
matrix:
include:
- os: linux
run: ubuntu-22.04
run: ubuntu-latest
- os: darwin
philipaconrad marked this conversation as resolved.
Show resolved Hide resolved
run: macos-latest
# Windows not allowed currently because of line-ending conversion issues.
Expand Down
7 changes: 5 additions & 2 deletions .github/workflows/manual-linter.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,14 @@ concurrency:
jobs:
go-lint:
name: Go Lint
runs-on: ubuntu-22.04
runs-on: ubuntu-latest
steps:
- name: Check out code
uses: actions/checkout@v3

- name: Golang Style and Lint Check
run: docker run --rm -v $(pwd):/app -w /app golangci/golangci-lint:v1.46.2 golangci-lint run -v
uses: golangci/golangci-lint-action@v3
timeout-minutes: 30
with:
# Optional: version of golangci-lint to use in form of v1.2 or v1.2.3 or `latest` to use the latest version
version: latest
9 changes: 6 additions & 3 deletions .github/workflows/pull-request.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,14 +11,17 @@ concurrency:
jobs:
go-lint:
name: Go Lint
runs-on: ubuntu-22.04
runs-on: ubuntu-latest
steps:
- name: Check out code
uses: actions/checkout@v3

- name: Golang Style and Lint Check
run: docker run --rm -v $(pwd):/app -w /app golangci/golangci-lint:v1.46.2 golangci-lint run -v
uses: golangci/golangci-lint-action@v3
timeout-minutes: 30
with:
# Optional: version of golangci-lint to use in form of v1.2 or v1.2.3 or `latest` to use the latest version
version: latest

go-test:
name: Go Test (${{ matrix.os }})
Expand All @@ -28,7 +31,7 @@ jobs:
matrix:
include:
- os: linux
run: ubuntu-22.04
run: ubuntu-latest
- os: darwin
philipaconrad marked this conversation as resolved.
Show resolved Hide resolved
run: macos-latest
# Windows not allowed currently because of line-ending conversion issues.
Expand Down