Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement(core): const init thread locals #15158

Merged
merged 1 commit into from
Nov 9, 2022

Conversation

arshiyasolei
Copy link
Contributor

Const init the thread locals based on the work here: rust-lang/rust#83416

@netlify
Copy link

netlify bot commented Nov 9, 2022

Deploy Preview for vector-project ready!

Name Link
🔨 Latest commit 8891f89
🔍 Latest deploy log https://app.netlify.com/sites/vector-project/deploys/636bd58eacf44a000872f269
😎 Deploy Preview https://deploy-preview-15158--vector-project.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added the domain: core Anything related to core crates i.e. vector-core, core-common, etc label Nov 9, 2022
@netlify
Copy link

netlify bot commented Nov 9, 2022

Deploy Preview for vrl-playground ready!

Name Link
🔨 Latest commit 8891f89
🔍 Latest deploy log https://app.netlify.com/sites/vrl-playground/deploys/636bd58e617904000878c9f2
😎 Deploy Preview https://deploy-preview-15158--vrl-playground.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

github-actions bot commented Nov 9, 2022

Regression Test Results

Baseline: c17294b
Comparison: 8891f89
Total vector CPUs: 4

Explanation

A regression test is an integrated performance test for vector in a repeatable rig, with varying configuration for vector. What follows is a statistical summary of a brief vector run for each configuration across SHAs given above. The goal of these tests are to determine, quickly, if vector performance is changed and to what degree by a pull request. Where appropriate units are scaled per-core.

The table below, if present, lists those experiments that have experienced a statistically significant change in their bytes_written_per_cpu_second performance between baseline and comparision SHAs, with 90.0% confidence OR have been detected as newly erratic. Negative values mean that baseline is faster, positive comparison. Results that do not exhibit more than a ±5% change in mean bytes_written_per_cpu_second are discarded. An experiment is erratic if its coefficient of variation is greater than 0.1. The abbreviated table will be omitted if no interesting changes are observed.

No interesting changes in bytes_written_per_cpu_second with confidence ≥ 90.00% and absolute Δ mean >= ±5%:

Fine details of change detection per experiment.
experiment Δ mean Δ mean % confidence baseline mean baseline stdev baseline stderr baseline outlier % baseline CoV comparison mean comparison stdev comparison stderr comparison outlier % comparison CoV erratic declared erratic
syslog_regex_logs2metric_ddmetrics 256.41KiB/CPU-s 4.26 100.00% 5.88MiB/CPU-s 600.79KiB/CPU-s 7.75KiB/CPU-s 0.0 0.099754 6.13MiB/CPU-s 415.19KiB/CPU-s 5.36KiB/CPU-s 0.0 0.066122 False False
datadog_agent_remap_datadog_logs_acks 473.07KiB/CPU-s 1.42 100.00% 32.5MiB/CPU-s 1.31MiB/CPU-s 17.35KiB/CPU-s 0.0 0.040419 32.96MiB/CPU-s 643.48KiB/CPU-s 8.31KiB/CPU-s 0.0 0.019064 False False
datadog_agent_remap_blackhole 511.31KiB/CPU-s 1.24 100.00% 40.2MiB/CPU-s 1.24MiB/CPU-s 16.46KiB/CPU-s 0.0 0.030956 40.7MiB/CPU-s 1.36MiB/CPU-s 17.93KiB/CPU-s 0.0 0.033347 False False
datadog_agent_remap_blackhole_acks 524.18KiB/CPU-s 1.23 100.00% 41.49MiB/CPU-s 1.05MiB/CPU-s 13.83KiB/CPU-s 0.0 0.025218 42.01MiB/CPU-s 1.1MiB/CPU-s 14.56KiB/CPU-s 0.0 0.026216 False False
otlp_grpc_to_blackhole 15.81KiB/CPU-s 0.95 100.00% 1.62MiB/CPU-s 86.35KiB/CPU-s 1.11KiB/CPU-s 0.0 0.052003 1.64MiB/CPU-s 74.97KiB/CPU-s 990.71B/CPU-s 0.0 0.044722 False False
datadog_agent_remap_datadog_logs 219.32KiB/CPU-s 0.73 100.00% 29.28MiB/CPU-s 698.17KiB/CPU-s 9.02KiB/CPU-s 0.0 0.023287 29.49MiB/CPU-s 991.37KiB/CPU-s 12.79KiB/CPU-s 0.0 0.032826 False False
syslog_humio_logs 96.19KiB/CPU-s 0.69 100.00% 13.61MiB/CPU-s 480.05KiB/CPU-s 6.2KiB/CPU-s 0.0 0.034442 13.7MiB/CPU-s 298.03KiB/CPU-s 3.85KiB/CPU-s 0.0 0.021236 False False
syslog_loki 43.91KiB/CPU-s 0.31 100.00% 13.85MiB/CPU-s 446.78KiB/CPU-s 5.77KiB/CPU-s 0.0 0.031494 13.9MiB/CPU-s 353.97KiB/CPU-s 4.57KiB/CPU-s 0.0 0.024875 False False
splunk_hec_to_splunk_hec_logs_noack 40.34KiB/CPU-s 0.21 99.63% 18.69MiB/CPU-s 766.93KiB/CPU-s 9.9KiB/CPU-s 0.0 0.040067 18.73MiB/CPU-s 756.34KiB/CPU-s 9.76KiB/CPU-s 0.0 0.039431 False False
splunk_hec_indexer_ack_blackhole 1.68KiB/CPU-s 0.01 17.04% 23.83MiB/CPU-s 434.52KiB/CPU-s 5.61KiB/CPU-s 0.0 0.017806 23.83MiB/CPU-s 420.59KiB/CPU-s 5.43KiB/CPU-s 0.0 0.017234 False False
splunk_hec_route_s3 1.55KiB/CPU-s 0.01 7.50% 13.37MiB/CPU-s 908.12KiB/CPU-s 11.72KiB/CPU-s 0.0 0.066349 13.37MiB/CPU-s 901.36KiB/CPU-s 11.63KiB/CPU-s 0.0 0.065847 False False
enterprise_http_to_http 215.54B/CPU-s 0.00 3.46% 23.84MiB/CPU-s 266.32KiB/CPU-s 3.44KiB/CPU-s 0.0 0.010907 23.84MiB/CPU-s 264.98KiB/CPU-s 3.42KiB/CPU-s 0.0 0.010852 False False
file_to_blackhole -13.55KiB/CPU-s -0.01 4.25% 92.49MiB/CPU-s 13.7MiB/CPU-s 180.83KiB/CPU-s 0.0 0.148076 92.48MiB/CPU-s 13.53MiB/CPU-s 178.61KiB/CPU-s 0.0 0.146342 True False
fluent_elasticsearch -14.71KiB/CPU-s -0.02 90.96% 79.47MiB/CPU-s 54.62KiB/CPU-s 714.71B/CPU-s 0.0 0.000671 79.46MiB/CPU-s 678.22KiB/CPU-s 8.66KiB/CPU-s 0.0 0.008335 False False
http_to_http_noack -10.72KiB/CPU-s -0.04 88.89% 23.84MiB/CPU-s 264.54KiB/CPU-s 3.42KiB/CPU-s 0.0 0.010835 23.83MiB/CPU-s 448.81KiB/CPU-s 5.79KiB/CPU-s 0.0 0.018390 False False
splunk_hec_to_splunk_hec_logs_acks -49.8KiB/CPU-s -0.27 99.82% 18.23MiB/CPU-s 888.61KiB/CPU-s 11.47KiB/CPU-s 0.0 0.047598 18.18MiB/CPU-s 855.81KiB/CPU-s 11.04KiB/CPU-s 0.0 0.045964 False False
http_pipelines_blackhole -4.02KiB/CPU-s -0.42 100.00% 968.34KiB/CPU-s 22.64KiB/CPU-s 299.49B/CPU-s 0.0 0.023376 964.32KiB/CPU-s 43.36KiB/CPU-s 573.04B/CPU-s 0.0 0.044962 False False
http_pipelines_blackhole_acks -3.72KiB/CPU-s -0.49 100.00% 753.72KiB/CPU-s 24.18KiB/CPU-s 319.69B/CPU-s 0.0 0.032081 750.0KiB/CPU-s 20.35KiB/CPU-s 268.96B/CPU-s 0.0 0.027127 False False
http_pipelines_no_grok_blackhole -31.01KiB/CPU-s -0.54 100.00% 5.66MiB/CPU-s 77.86KiB/CPU-s 1.01KiB/CPU-s 0.0 0.013434 5.63MiB/CPU-s 125.71KiB/CPU-s 1.62KiB/CPU-s 0.0 0.021807 False False
syslog_splunk_hec_logs -78.84KiB/CPU-s -0.56 100.00% 13.79MiB/CPU-s 251.88KiB/CPU-s 3.25KiB/CPU-s 0.0 0.017841 13.71MiB/CPU-s 379.28KiB/CPU-s 4.9KiB/CPU-s 0.0 0.027015 False False
otlp_http_to_blackhole -14.94KiB/CPU-s -0.61 99.90% 2.41MiB/CPU-s 241.21KiB/CPU-s 3.11KiB/CPU-s 0.0 0.097839 2.39MiB/CPU-s 256.7KiB/CPU-s 3.31KiB/CPU-s 0.0 0.104758 True False
http_to_http_acks -70.71KiB/CPU-s -0.69 47.27% 9.96MiB/CPU-s 6.02MiB/CPU-s 79.57KiB/CPU-s 0.0 0.604027 9.9MiB/CPU-s 5.94MiB/CPU-s 78.61KiB/CPU-s 0.0 0.600647 True False
http_to_http_json -270.1KiB/CPU-s -1.11 100.00% 23.84MiB/CPU-s 376.06KiB/CPU-s 4.85KiB/CPU-s 0.0 0.015403 23.58MiB/CPU-s 785.46KiB/CPU-s 10.14KiB/CPU-s 0.0 0.032531 False False
http_text_to_http_json -471.08KiB/CPU-s -1.21 100.00% 37.9MiB/CPU-s 862.67KiB/CPU-s 11.14KiB/CPU-s 0.0 0.022224 37.44MiB/CPU-s 1.38MiB/CPU-s 18.28KiB/CPU-s 0.0 0.036905 False False
syslog_log2metric_humio_metrics -108.1KiB/CPU-s -1.38 100.00% 7.64MiB/CPU-s 200.85KiB/CPU-s 2.59KiB/CPU-s 0.0 0.025670 7.53MiB/CPU-s 265.25KiB/CPU-s 3.42KiB/CPU-s 0.0 0.034376 False False
socket_to_socket_blackhole -428.79KiB/CPU-s -1.82 100.00% 23.03MiB/CPU-s 514.85KiB/CPU-s 6.64KiB/CPU-s 0.0 0.021830 22.61MiB/CPU-s 710.44KiB/CPU-s 9.17KiB/CPU-s 0.0 0.030681 False False
syslog_log2metric_splunk_hec_metrics -312.93KiB/CPU-s -2.22 100.00% 13.76MiB/CPU-s 266.17KiB/CPU-s 3.44KiB/CPU-s 0.0 0.018894 13.45MiB/CPU-s 454.56KiB/CPU-s 5.87KiB/CPU-s 0.0 0.032999 False False

@github-actions
Copy link

github-actions bot commented Nov 9, 2022

Soak Test Results

Baseline: c17294b
Comparison: 8891f89
Total Vector CPUs: 4

Explanation

A soak test is an integrated performance test for vector in a repeatable rig, with varying configuration for vector. What follows is a statistical summary of a brief vector run for each configuration across SHAs given above. The goal of these tests are to determine, quickly, if vector performance is changed and to what degree by a pull request. Where appropriate units are scaled per-core.

The table below, if present, lists those experiments that have experienced a statistically significant change in their throughput performance between baseline and comparision SHAs, with 90.0% confidence OR have been detected as newly erratic. Negative values mean that baseline is faster, positive comparison. Results that do not exhibit more than a ±8.87% change in mean throughput are discarded. An experiment is erratic if its coefficient of variation is greater than 0.3. The abbreviated table will be omitted if no interesting changes are observed.

No interesting changes in throughput with confidence ≥ 90.00% and absolute Δ mean >= ±8.87%:

Fine details of change detection per experiment.
experiment Δ mean Δ mean % confidence baseline mean baseline stdev baseline stderr baseline outlier % baseline CoV comparison mean comparison stdev comparison stderr comparison outlier % comparison CoV erratic declared erratic
http_text_to_http_json 563.66KiB 1.39 100.00% 39.51MiB 730.07KiB 14.9KiB 0 0.0180425 40.06MiB 719.33KiB 14.69KiB 0 0.0175328 False False
socket_to_socket_blackhole 241.77KiB 1 100.00% 23.58MiB 125.1KiB 2.55KiB 0 0.00517969 23.82MiB 296.38KiB 6.05KiB 0 0.01215 False False
http_pipelines_blackhole_acks 28.18KiB 0.83 99.96% 3.32MiB 329.19KiB 6.69KiB 0 0.0967354 3.35MiB 207.45KiB 4.23KiB 0 0.0604597 False False
datadog_agent_remap_blackhole_acks 372.2KiB 0.63 99.99% 57.62MiB 4.17MiB 86.79KiB 0 0.072324 57.99MiB 2.02MiB 42.36KiB 0 0.0348739 False False
splunk_hec_to_splunk_hec_logs_noack 22.67KiB 0.09 93.02% 23.82MiB 512.07KiB 10.45KiB 0 0.020992 23.84MiB 335.84KiB 6.86KiB 0 0.0137549 False False
splunk_hec_to_splunk_hec_logs_acks 4.84KiB 0.02 16.18% 23.76MiB 834.4KiB 16.98KiB 0 0.0342897 23.76MiB 813.73KiB 16.56KiB 0 0.0334336 False False
splunk_hec_route_s3 227.47B 0 0.30% 21.64MiB 2.09MiB 43.58KiB 0 0.0966667 21.64MiB 1.96MiB 41.11KiB 0 0.0907516 False False
enterprise_http_to_http -1.4KiB -0.01 15.28% 23.85MiB 248.98KiB 5.08KiB 0 0.0101941 23.85MiB 252.75KiB 5.17KiB 0 0.010349 False False
splunk_hec_indexer_ack_blackhole -9.67KiB -0.04 28.06% 23.75MiB 901.38KiB 18.33KiB 0 0.0370583 23.74MiB 969.13KiB 19.71KiB 0 0.0398595 False False
file_to_blackhole -59.55KiB -0.06 42.35% 95.34MiB 3.2MiB 66.32KiB 0 0.0335487 95.28MiB 4.01MiB 83.5KiB 0 0.0421153 False False
syslog_splunk_hec_logs -15.3KiB -0.09 56.58% 15.73MiB 718.08KiB 14.62KiB 0 0.0445805 15.71MiB 637.39KiB 12.99KiB 0 0.0396087 False False
http_to_http_json -41.65KiB -0.17 99.64% 23.84MiB 394.44KiB 8.05KiB 0 0.016151 23.8MiB 578.97KiB 11.81KiB 0 0.0237471 False False
fluent_elasticsearch -175.63KiB -0.22 100.00% 79.47MiB 52.28KiB 1.06KiB 0 0.000642231 79.3MiB 1.6MiB 32.95KiB 0 0.0201835 False False
http_to_http_acks -41.91KiB -0.24 13.78% 17.19MiB 8.28MiB 173.07KiB 0 0.481613 17.14MiB 8.06MiB 168.28KiB 0 0.469777 True True
http_pipelines_blackhole -14.78KiB -0.32 93.26% 4.48MiB 138.02KiB 2.82KiB 0 0.030112 4.46MiB 371.74KiB 7.57KiB 0 0.0813654 False False
http_to_http_noack -87.75KiB -0.36 99.99% 23.85MiB 250.0KiB 5.11KiB 0 0.0102358 23.76MiB 1.02MiB 21.25KiB 0 0.0428686 False False
syslog_regex_logs2metric_ddmetrics -51.38KiB -0.65 96.47% 7.77MiB 847.89KiB 17.26KiB 0 0.106526 7.72MiB 846.01KiB 17.24KiB 0 0.10698 False False
datadog_agent_remap_datadog_logs_acks -377.22KiB -0.68 99.96% 53.8MiB 3.2MiB 66.76KiB 0 0.0594017 53.43MiB 3.95MiB 82.22KiB 0 0.0739099 False False
syslog_log2metric_splunk_hec_metrics -126.32KiB -0.76 100.00% 16.21MiB 530.51KiB 10.81KiB 0 0.031956 16.09MiB 479.56KiB 9.78KiB 0 0.029108 False False
datadog_agent_remap_datadog_logs -513.17KiB -0.93 100.00% 53.98MiB 490.48KiB 10.04KiB 0 0.00887227 53.47MiB 3.69MiB 76.8KiB 0 0.0689687 False False
syslog_loki -250.48KiB -1.58 100.00% 15.49MiB 301.03KiB 6.17KiB 0 0.018977 15.24MiB 761.12KiB 15.47KiB 0 0.0487509 False False
syslog_humio_logs -314.87KiB -1.88 100.00% 16.37MiB 147.38KiB 3.01KiB 0 0.00879219 16.06MiB 215.22KiB 4.4KiB 0 0.0130855 False False
datadog_agent_remap_blackhole -1.26MiB -2.26 100.00% 56.08MiB 3.71MiB 77.27KiB 0 0.0660607 54.81MiB 3.19MiB 66.58KiB 0 0.0582127 False False
http_pipelines_no_grok_blackhole -244.44KiB -2.28 100.00% 10.45MiB 221.85KiB 4.53KiB 0 0.0207311 10.21MiB 1014.89KiB 20.64KiB 0 0.0970565 False False
syslog_log2metric_humio_metrics -258.86KiB -2.68 100.00% 9.43MiB 165.13KiB 3.37KiB 0 0.0170937 9.18MiB 426.94KiB 8.68KiB 0 0.0454136 False False

@arshiyasolei arshiyasolei merged commit 31383ef into master Nov 9, 2022
@arshiyasolei arshiyasolei deleted the arshiyasolei/const-thread-local branch November 9, 2022 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: core Anything related to core crates i.e. vector-core, core-common, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants