Invoke post_compile hook before install and add pre/post_install hooks #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the PR, I believe the expectation that post_compile runs after the compilation is completely legit. |
|
I just added the new hooks to the README. |
|
Perfect, thank you. I'll release it to the buildpack registry in a moment. EDIT: the vapor/vapor buildpack is now up to date. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing time of hook execution
This PR moves the invocation of the post_compile script up some lines, right after
swift-compilehas completed and beforeswift-installis executed.It also adds a pre_install and a post_install hook too.
Description
I have a task which must be executed against the .build folder. Mainly a script that copies the
/Resources/*folder out of a dependent package. (I'm using Leaf in a dependency, but Leaf is unable to render files that are packaged with SPM in a dependency).Therefore, I tried a post_compile script like
cp -r $BUILD_DIR/.build/checkouts/repo/Resources .But since the
post_compilescript is executed afterswift-install, the.buildfolder is already gone. This PR resolves this case.