Underlying test #63
Merged
Underlying test #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xAlcibiades
requested changes
Oct 7, 2022
…core into master_underlying_data_issue
0xAlcibiades
approved these changes
Oct 20, 2022
| @@ -411,7 +411,7 @@ contract OptionSettlementEngine is ERC1155, IOptionSettlementEngine { | |||
| function underlying(uint256 tokenId) external view returns (Underlying memory underlyingPositions) { | |||
| (uint160 optionId, uint96 claimIdx) = getDecodedIdComponents(tokenId); | |||
|
|
|||
| if (!_isOptionInitialized(optionId)) { | |||
| if (!isOptionInitialized(optionId)) { | |||
There was a problem hiding this comment.
Is there a reason you didn't use the private accessor here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DRY tests; add test for checking underlying after exercise
Adding test for #50