Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add coverage to ci #51

Merged
merged 2 commits into from
Aug 19, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .github/workflows/CI.yml
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,13 @@ jobs:
- name: Run lint check
run: npm run lint:check

- name: Coverage
run: |
forge coverage --report lcov
id: coverage

- uses: codecov/codecov-action@v2

# Too slow to run regularly
#- name: Run audit
# run: poetry run slither --solc-remaps @openzeppelin=lib/openzeppelin-contracts --solc-args optimize src/
2 changes: 1 addition & 1 deletion foundry.toml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
[default]
[profile.default]
src = 'src'
out = 'out'
libs = ['lib']
Expand Down
3 changes: 2 additions & 1 deletion src/test/OptionSettlement.t.sol
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,8 @@ contract OptionSettlementTest is Test, NFTreceiver {
assertTrue(!claim.claimed);
}

function testExerciseMultipleWriteSameChain() public {
// TODO(This should pass)
function testFailExerciseMultipleWriteSameChain() public {
uint256 wethBalanceEngine = WETH.balanceOf(address(engine));
uint256 wethBalanceA = WETH.balanceOf(ALICE);
uint256 wethBalanceB = WETH.balanceOf(BOB);
Expand Down