clean test file for reimplemenation #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pegahcarter
approved these changes
Apr 18, 2022
pegahcarter
reviewed
Apr 18, 2022
| WETH.approve(address(engine), type(uint256).max); | ||
| DAI.approve(address(engine), type(uint256).max); | ||
| USDC.approve(address(engine), type(uint256).max); | ||
| // TODO(Why) | ||
| engine.setApprovalForAll(address(this), true); |
There was a problem hiding this comment.
This is for any future transfers that need to be done. We might as well pre-approve the contract
2 tasks
pegahcarter
reviewed
Apr 18, 2022
| exerciseTimestamp: uint40(block.timestamp), | ||
| expiryTimestamp: (uint40(block.timestamp) + 604800) | ||
| }); | ||
| IOptionSettlementEngine.Option memory option = IOptionSettlementEngine |
There was a problem hiding this comment.
Having this obj in contract wide storage would help shortening other tests as we would not have to re-declare a whole option, just set a new one in memory to point to the storage one and modify the desired attributes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.