Audit #30
Merged
Audit #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 13, 2022 13:51
0xAlcibiades
requested changes
Apr 14, 2022
src/test/OptionSettlement.t.sol
Outdated
| @@ -43,18 +43,27 @@ contract OptionSettlementTest is DSTest, NFTreceiver { | |||
| OptionSettlementEngine public engine; | |||
|
|
|||
| address public immutable ac = 0x36273803306a3C22bc848f8Db761e974697ece0d; | |||
| address public immutable wethAddress = | |||
| address public WETH = | |||
There was a problem hiding this comment.
Any reason these cant be immutable?
| @@ -0,0 +1,105 @@ | |||
| ``` | |||
There was a problem hiding this comment.
No reason to include this here, can run slither on demand as needed, but also not useful to run on the libraries/false positive on the base64 encode
There was a problem hiding this comment.
See the commented out slither command in the CI pipeline, would be preferable to just get that working and have the output on each pipeline.
.solhintignore
Outdated
| @@ -0,0 +1 @@ | |||
| test/OptionSettlement.t.sol | |||
There was a problem hiding this comment.
Ignoring the tests is not the way, why not just make them pass lint?
There was a problem hiding this comment.
Fair enough - I will revise as so
added 4 commits
April 14, 2022 12:51
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.