🔧 Standardize CI across active protocol repos

[neodaoist]

No description provided.

[linear]

VAL-489 Standardize CI across active protocol repos

• Remove hardcoded RPC (initially due to a GH secrets bug), esp if not using rn

[megsdevs]

https://github.com/valorem-labs-inc/clear/actions/runs/5481343531/jobs/9985521776?pr=212#step:6:332

Need to either fix the URI encoding, or disable the slither URI warning, either per line or globally. I assume you might not want to touch the solidity code so may be preferable to disable globally.

Not sure why slither didn't pick this up before it was changed for this commit? @0xAlcibiades

[megsdevs]

if you run slither locally it shows you the high priority warnings in red

highly recommend using solc-select when using slither, this was the issue i was having to run locally before:
https://github.com/crytic/solc-select

then to select version use solc-select use 0.8.16 --always-install

[megsdevs]

although @0xAlcibiades @neodaoist can we check this isn't highlighting some unintended behaviour with the uri given the params are dynamic, it can cause clashes?

clear/src/TokenURIGenerator.sol

Lines 49 to 62 in 63c717e

	return string(
	abi.encodePacked(
	_escapeQuotes(params.underlyingSymbol),
	_escapeQuotes(params.exerciseSymbol),
	yearDigits[2],
	yearDigits[3],
	monthDigits.length == 2 ? monthDigits[0] : bytes1(uint8(48)),
	monthDigits.length == 2 ? monthDigits[1] : monthDigits[0],
	dayDigits.length == 2 ? dayDigits[0] : bytes1(uint8(48)),
	dayDigits.length == 2 ? dayDigits[1] : dayDigits[0],
	"C"
	)
	);
	}

see https://github.com/crytic/slither/wiki/Detector-Documentation#abi-encodePacked-collision

[codecov]

Codecov Report

Merging #212 (63c717e) into release/v1.0.1 (d3458f1) will not change coverage.
The diff coverage is n/a.

❗ Current head 63c717e differs from pull request most recent head 8a859cd. Consider uploading reports for the commit 8a859cd to get more accurate results

@@               Coverage Diff               @@
##           release/v1.0.1     #212   +/-   ##
===============================================
  Coverage           99.20%   99.20%           
===============================================
  Files                   1        1           
  Lines                 250      250           
  Branches               41       41           
===============================================
  Hits                  248      248           
  Partials                2        2