Support off-chain claim accounting via bucket events #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neodaoist
commented
Jan 24, 2023
| @@ -598,7 +600,7 @@ contract OptionSettlementEngine is ERC1155, IOptionSettlementEngine { | |||
| address underlyingAsset = optionRecord.underlyingAsset; | |||
|
|
|||
| // Assign exercise to writers. | |||
| _assignExercise(optionTypeState, optionRecord, amount); | |||
| _assignExercise(optionId, optionTypeState, optionRecord, amount); | |||
There was a problem hiding this comment.
BTW, with the entropy + weighting changes, it's likely that we can drop optionRecord from the function params.
neodaoist
commented
Jan 24, 2023
| amountPresentlyExercised = amount; | ||
| amount = 0; | ||
| } | ||
| bucketInfo.amountExercised += amountPresentlyExercised; | ||
|
|
||
| emit BucketAssignedExercise(optionId, bucketIndex, amountPresentlyExercised); |
There was a problem hiding this comment.
I believe amountPresentlyExercised is the correct argument to include here — the amount of options that were just assigned exercised from this bucket.
neodaoist
changed the title
0xAlcibiades
requested changes
Jan 25, 2023
| * @param bucketIndex The index of the bucket to which the options were written. | ||
| * @param amount The amount of options contracts written. | ||
| */ | ||
| event BucketWrittenInto(uint256 indexed optionId, uint96 bucketIndex, uint112 amount); |
There was a problem hiding this comment.
I think this should have the claim ID indexed for the subgraph handler to know.
There was a problem hiding this comment.
RIght on, good call, will add
0xAlcibiades
approved these changes
Jan 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes in this PR —
BucketWrittenIntoeventBucketAssignedExerciseeventWill save for the more significant entropy and weighting PRs —