-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reorganize unit/integration tests and deduplicate #168
Conversation
Codecov Report
@@ Coverage Diff @@
## audit-fixes #168 +/- ##
===============================================
+ Coverage 90.05% 91.12% +1.07%
===============================================
Files 2 2
Lines 372 372
Branches 56 56
===============================================
+ Hits 335 339 +4
+ Misses 29 27 -2
+ Partials 8 6 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
The 2 logic branches not covered by the unit tests weren't covered by the whole test suite to begin with, would be great to track them down @neodaoist. |
Might be unreachable code, actually. |
@0xAlcibiades want to back out the changes to the actor files? Those will conflict with the changes I'm making, and it looks like they're not substantive changes |
Reorganize unit tests to maximize compatibility with audit threat model to easily add needed additional cases. Additionally, remove duplicate coverage, complete refactor to separate file organization.
We can now more easily extend fuzz coverage, and add a sweeping integration test if we are inclined, though fuzzing and invariant testing may preclude.