Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize unit/integration tests and deduplicate #168

Merged
merged 36 commits into from
Dec 22, 2022

Conversation

0xAlcibiades
Copy link
Member

@0xAlcibiades 0xAlcibiades commented Dec 22, 2022

Reorganize unit tests to maximize compatibility with audit threat model to easily add needed additional cases. Additionally, remove duplicate coverage, complete refactor to separate file organization.

Screen Shot 2022-12-22 at 03 32 28

We can now more easily extend fuzz coverage, and add a sweeping integration test if we are inclined, though fuzzing and invariant testing may preclude.

@codecov-commenter
Copy link

codecov-commenter commented Dec 22, 2022

Codecov Report

Merging #168 (52bd232) into audit-fixes (27dddb5) will increase coverage by 1.07%.
The diff coverage is n/a.

@@               Coverage Diff               @@
##           audit-fixes     #168      +/-   ##
===============================================
+ Coverage        90.05%   91.12%   +1.07%     
===============================================
  Files                2        2              
  Lines              372      372              
  Branches            56       56              
===============================================
+ Hits               335      339       +4     
+ Misses              29       27       -2     
+ Partials             8        6       -2     
Impacted Files Coverage Δ
src/OptionSettlementEngine.sol 99.18% <0.00%> (+1.63%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@0xAlcibiades
Copy link
Member Author

The 2 logic branches not covered by the unit tests weren't covered by the whole test suite to begin with, would be great to track them down @neodaoist.

@0xAlcibiades
Copy link
Member Author

The 2 logic branches not covered by the unit tests weren't covered by the whole test suite to begin with, would be great to track them down @neodaoist.

Might be unreachable code, actually.

@0xAlcibiades 0xAlcibiades changed the title WIP: reimplement unit tests Reorganize unit/integration tests and deduplicate Dec 22, 2022
@Flip-Liquid
Copy link
Contributor

@0xAlcibiades want to back out the changes to the actor files? Those will conflict with the changes I'm making, and it looks like they're not substantive changes

@0xAlcibiades 0xAlcibiades merged commit 0cc7818 into audit-fixes Dec 22, 2022
@0xAlcibiades 0xAlcibiades deleted the report_review branch December 22, 2022 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants