Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rehash storage layout #146

Merged
merged 11 commits into from
Dec 9, 2022
Merged

Rehash storage layout #146

merged 11 commits into from
Dec 9, 2022

Conversation

0xAlcibiades
Copy link
Member

No description provided.

@0xAlcibiades 0xAlcibiades changed the base branch from master to audit-fixes December 9, 2022 22:44
@codecov-commenter
Copy link

codecov-commenter commented Dec 9, 2022 •
edited
Loading

Codecov Report

Merging #146 (28f98bb) into audit-fixes (eaefae3) will increase coverage by 0.13%.
The diff coverage is 100.00%.

❗ Current head 28f98bb differs from pull request most recent head d83c2dd. Consider uploading reports for the commit d83c2dd to get more accurate results

@@               Coverage Diff               @@
##           audit-fixes     #146      +/-   ##
===============================================
+ Coverage        88.56%   88.69%   +0.13%     
===============================================
  Files                2        2              
  Lines              341      345       +4     
  Branches            52       52              
===============================================
+ Hits               302      306       +4     
  Misses              30       30              
  Partials             9        9
Impacted Files Coverage Δ
src/OptionSettlementEngine.sol 99.07% <100.00%> (+0.01%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Flip-Liquid
Flip-Liquid approved these changes Dec 9, 2022
View reviewed changes
Copy link
Contributor

@Flip-Liquid Flip-Liquid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work! :)

@0xAlcibiades 0xAlcibiades merged commit aa5b23f into audit-fixes Dec 9, 2022
@0xAlcibiades 0xAlcibiades deleted the enhancement/storage_layout branch December 9, 2022 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Flip-Liquid Flip-Liquid Flip-Liquid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@0xAlcibiades @codecov-commenter @Flip-Liquid @neodaoist