Perform multiplication before division for fee calculations #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xAlcibiades
changed the base branch from
master
to
fix/events-before-external
0xAlcibiades
approved these changes
Dec 5, 2022
|
@neodaoist I've not been following the eventing/ordering of event emission as closely as i should be but i noticed this PR is changing the ordering again. is that intentional or has something crept back in here? |
Codecov Report
@@ Coverage Diff @@
## audit-fixes #132 +/- ##
==============================================
Coverage ? 88.72%
==============================================
Files ? 2
Lines ? 346
Branches ? 54
==============================================
Hits ? 307
Misses ? 30
Partials ? 9 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.