Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move feeTo from hardcoded to constructor arg #112

Merged
merged 1 commit into from
Nov 17, 2022
Merged

Move feeTo from hardcoded to constructor arg #112

merged 1 commit into from
Nov 17, 2022

Conversation

neodaoist
Copy link
Contributor

Resolves #111

0xAlcibiades
0xAlcibiades requested changes Nov 17, 2022
View reviewed changes
Copy link
Member

@0xAlcibiades 0xAlcibiades left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick question on your thoughts @neodaoist

src/OptionSettlementEngine.sol Show resolved Hide resolved
@0xAlcibiades 0xAlcibiades merged commit 9fb24f7 into master Nov 17, 2022
@neodaoist neodaoist deleted the feature/feeto-as-constructor-arg branch November 17, 2022 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xAlcibiades 0xAlcibiades 0xAlcibiades approved these changes

@Flip-Liquid Flip-Liquid Awaiting requested review from Flip-Liquid

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move feeTo address into constructor arg
2 participants
@neodaoist @0xAlcibiades