fixups #106
Merged
fixups #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Flip-Liquid
commented
Nov 17, 2022
Flip-Liquid
commented
- fix accessor
- update comments
- drop TODOs
Codecov Report
@@ Coverage Diff @@
## master #106 +/- ##
==========================================
- Coverage 86.49% 86.45% -0.04%
==========================================
Files 3 3
Lines 348 347 -1
Branches 52 52
==========================================
- Hits 301 300 -1
Misses 36 36
Partials 11 11
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
neodaoist
reviewed
Nov 17, 2022
0xAlcibiades
approved these changes
Nov 17, 2022
|
No use getting too deep on semantics/naming, approved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.